Enable guest debugging for HyperV on windows #478
+1,054
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblnz
added
the
kind/enhancement
|
Nice. Any chance we could land this after #469? :P |
|
Yes, I was thinking on doing that to be less work for solving conflicts |
dblnz
force-pushed
the
gdb-debugging-windows
branch
2 times, most recently
from
9afdaba to
c5caf69
Compare
dblnz
requested review from
danbugs,
ludfjig,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
dblnz
changed the title
- Previously, interrupting a running vCPU under debug meant directly sending a SIGINT signal, since we have a way to handle interrupt sending, there is no need to do that. Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
dblnz
force-pushed
the
gdb-debugging-windows
branch
from
c5caf69 to
bde9c7d
Compare
There was a problem hiding this comment.
Great stuff, One small comment, lets get @ludfjig to review this one last time before we merge
| @@ -90,7 +90,7 @@ fn main() -> Result<()> { | |||
| // Essentially the kvm and mshv features are ignored on windows as long as you use #[cfg(kvm)] and not #[cfg(feature = "kvm")]. | |||
| // You should never use #[cfg(feature = "kvm")] or #[cfg(feature = "mshv")] in the codebase. | |||
| cfg_aliases::cfg_aliases! { | |||
| gdb: { all(feature = "gdb", debug_assertions, any(feature = "kvm", feature = "mshv2", feature = "mshv3"), target_os = "linux") }, | |||
| gdb: { all(feature = "gdb", debug_assertions, any(feature = "kvm", feature = "mshv2", feature = "mshv3")) }, | |||
There was a problem hiding this comment.
Do we still need any(feature = "kvm", feature = "mshv2", feature = "mshv3") since its now enabled for all hypervisors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #241
This brings the same debugging behavior to windows guests as kvm and mshv guests have on linux.
Some of the duplicated debug logic that is implemented on each hypervisor driver will be refactored later in a single implementation.
Copilot Generated Description
This pull request introduces significant updates to the Hyperlight debugging functionality, expanding support to Windows environments, refactoring the codebase to improve modularity, and enhancing the debugging capabilities. The most important changes include adding Windows-specific signal handling, introducing the
HypervDebugstruct for Hyper-V guest debugging, and removing Linux-specific dependencies from cross-platform code.Cross-platform debugging enhancements:
src/hyperlight_host/src/hypervisor/gdb/event_loop.rs: Added conditional compilation for signal handling to differentiate between Linux (libc::SIGINT,libc::SIGSEGV) and Windows (SIGINT,SIGSEGV). Updated signal handling logic to use platform-specific signals. [1] [2]src/hyperlight_host/build.rs: Removed Linux-specific constraints from thegdbfeature configuration, allowing debugging on Windows.Windows debugging support:
src/hyperlight_host/src/hypervisor/gdb/hyperv_debug.rs: Added theHypervDebugstruct to implement debugging functionalities for Hyper-V guests, including hardware and software breakpoints, register manipulation, and vCPU stop reason handling.src/hyperlight_host/src/hypervisor/gdb/mod.rs: IntegratedHypervDebuginto the debugging module and updated theGuestDebugtrait visibility topub(super)for better encapsulation. [1] [2] [3]Refactoring for improved modularity:
src/hyperlight_host/src/hypervisor/gdb/x86_64_target.rs: Replaced the thread ID with anInterruptHandlefor vCPU thread management. Added methods for setting the interrupt handle and interrupting vCPU execution. Updated tests to reflect these changes. [1] [2] [3] [4]src/hyperlight_host/src/hypervisor/gdb/mod.rs: Refactoredcreate_gdb_threadto handle the newInterruptHandlemechanism and updated the communication protocol for initializing the debugger. [1] [2]Documentation updates:
docs/how-to-debug-a-hyperlight-guest.md: Updated documentation to reflect support for debugging on Windows and clarified the removal ofKVMandMSHVguest-specific mentions. [1] [2]These changes collectively enhance the flexibility of Hyperlight's debugging capabilities, making it more robust and suitable for cross-platform use.